Pearl1594 commented on a change in pull request #4676:
URL: https://github.com/apache/cloudstack/pull/4676#discussion_r604871925
##########
File path: ui/src/views/compute/InstanceTab.vue
##########
@@ -444,6 +461,15 @@ export default {
this.fetchPublicIps(record.nic.networkid)
}
},
+ onAcquireSecondaryIPAddress (record) {
+ if (record.nic.type === 'Shared') {
+ this.editNicResource = record.nic
+ this.editNetworkId = record.nic.networkid
Review comment:
@ravening I believe L466-467 need to be moved outside the if block as in
a case where we have one nic on an Isolated network & one on a shared network;
if you first attempt adding a secondary IP for the nic on a shared network and
then do the same for the nic on Isolated network, it continues to show the
shared n/ws public ips
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
