slavkap commented on a change in pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#discussion_r607629776
##########
File path: tools/marvin/marvin/config/test_data.py
##########
@@ -928,6 +928,16 @@
"ostype": "CentOS 5.6 (64-bit)",
"mode": 'HTTP_DOWNLOAD',
},
+ "iso3": {
+ "displaytext": "Test ISO 3",
+ "name": "ISO 3",
+ "url": "http://people.apache.org/~tsp/dummy.iso";,
Review comment:
@rhtyd, I tested it with UEFI enabled/disabled, and the test works as
expected, but it only checks the dumpxml of the domain, nothing more (that's
why I don't see a reason to add a valid ISO). Do I have to open a PR with the
changes of test_data.py to your repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
