GutoVeronezi opened a new pull request #4954:
URL: https://github.com/apache/cloudstack/pull/4954


   ### Description
   ACS has several features that need to send email through SMTP; However the 
code to send emails is repeated along the features.    
   Code repetition does not guarantee that sending email will work the same 
way, makes maintenance difficult and multiplies the work to add a new option, 
like `StartTLS`.
   
   This PR intends to create an util to send email through SMTP, to minimize 
code and to facilite maintenance, unit tests creation and troubleshooting.
   
   ### Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   - [ ] Major
   - [x] Minor
   
   ### How Has This Been Tested?
   I configured SMTP global configs to project, alert and quota.
   - To quota I added 10 credits to my user and set 20 as min balance, then I 
called `quota update` API via Cloudmonkey;
   - To project I added an user;
   - To alert called `generate alert` API via Cloudmonkey;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to