harikrishna-patnala commented on a change in pull request #4977:
URL: https://github.com/apache/cloudstack/pull/4977#discussion_r637890593
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -1390,10 +1390,12 @@ else if (volumeInfo.getFormat() == ImageFormat.OVA) {
verifyCopyCmdAnswer(copyCmdAnswer, templateInfo);
+ // Seems like vmware 6.5 and above does not automatically
remount the datastore after rescanning the storage.
+ // Not sure if this is needed.
// If using VMware, have the host rescan its software HBA if
dynamic discovery is in use.
- if
(HypervisorType.VMware.equals(templateInfo.getHypervisorType())) {
Review comment:
@skattoju4 There are two more methods in which
disconnectHostFromVolume() method is being called. Any specific reason why you
want to remove this method call only here. Can you check the other two methods
as well handleCreateManagedVolumeFromManagedSnapshot() and
handleCopyAsyncToSecondaryStorage(). These two are also related to managed
storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
