sureshanaparti commented on a change in pull request #5067:
URL: https://github.com/apache/cloudstack/pull/5067#discussion_r645499790



##########
File path: 
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
##########
@@ -1868,6 +1847,65 @@ protected Void 
copyVolumeCallBack(AsyncCallbackDispatcher<VolumeServiceImpl, Cop
         return null;
     }
 
+    @Override
+    public boolean 
copyPoliciesBetweenVolumesAndDestroySourceVolumeAfterMigration(Event 
destinationEvent, Answer destinationEventAnswer, VolumeInfo sourceVolume,
+      VolumeInfo destinationVolume, boolean retryExpungeVolumeAsync) {

Review comment:
       @GutoVeronezi I think, it is better to separate copy policies and 
destroy volume.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to