Pearl1594 opened a new pull request #5139:
URL: https://github.com/apache/cloudstack/pull/5139


   ### Description
   
   This PR fixes a compatibility issue noticed with deployDataCenter.py script 
when run with python3 - the script reports the following exception:
   ```
   Exception Occurred  while persisting DC Settings: ['Traceback (most recent 
call last):\n', '  File "tools/marvin/marvin/deployDataCenter.py", line 76, in 
__persistDcConfig\n    pickle.dump(self.__cleanUp, file_to_write)\n', 
'TypeError: write() argument must be str, not bytes\n']
   ```
   And hence doesn't create the dc_entries.obj file
   
   <!--- 
*********************************************************************************
 -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE 
DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- 
*********************************************************************************
 -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### How Has This Been Tested?
   Ran the deployDataCenter script using python2 and python3 - it runs 
successfully and generates the dc_entries.obj file in human readable format 
(which is controlled by the protocol number passed)
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) 
document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to