DaanHoogland commented on a change in pull request #5163:
URL: https://github.com/apache/cloudstack/pull/5163#discussion_r662885101
##########
File path: server/src/main/java/com/cloud/uuididentity/UUIDManagerImpl.java
##########
@@ -119,7 +119,9 @@ public boolean IsUuidFormat(String uuid) {
}
Identity identity = (Identity) this._entityMgr.findById(entityType,
customId);
Review comment:
Yhe NPE would be thrown in the call to `findById()` @sureshanaparti
@rhtyd
```
@Override
public <T, K extends Serializable> T findById(Class<T> entityType, K id)
{
GenericDao<? extends T, K> dao = (GenericDao<? extends T,
K>)GenericDaoBase.getDao(entityType);
return dao.findById(id);
}
```
I'm fine with applying the extra check in this case but I think it'll be
unreachable code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
