weizhouapache commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877679165


   > @weizhouapache Couldn't you have said this a few days earlier? This PR has 
been open for more than a year. 
   > 
   > Sure, I can submit another PR that reverts this... But only if it's 
confirmed that this isn't deprecated. @rhtyd @DaanHoogland ?
   
   @onitake I found the problem right after this pr is merged...
   
   maybe it is unnecessary to revert the pr as it is not an major issue, you 
can create a PR to (1) revert the change in CreateFirewallRuleCmd.java; (2) 
change CreateLoadBalancerRuleCmd.java and CreateIpForwardingRuleCmd.java 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to