shwstppr commented on a change in pull request #5233:
URL: https://github.com/apache/cloudstack/pull/5233#discussion_r674671873
##########
File path: ui/src/config/section/compute.js
##########
@@ -299,7 +299,7 @@ export default {
docHelp:
'adminguide/virtual_machines.html#how-to-dynamically-scale-cpu-and-ram',
dataView: true,
show: (record) => { return ['Stopped'].includes(record.state) ||
(['Running'].includes(record.state) && record.hypervisor !== 'KVM' &&
record.hypervisor !== 'LXC') },
- disabled: (record) => { return !record.isdynamicallyscalable },
+ disabled: (record) => { return !record.isdynamicallyscalable &&
record.state !== 'Stopped' },
Review comment:
@ravening In this case yes. My point was to check VM's state first and
isdynamicallyscalable later as that is relevant only for running VMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
