rhtyd commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-890098933


   @GutoVeronezi I'm not "messing things up", you pinged me on the issue #3609 
saying "There is a PR (#4699) that I think would solve this situation", now 
you're saying it doesn't.
   
   That's fine if you don't want to address the requested scope of changes, I 
had originally asked Hari on the issue to explore a solution which is now 
explored by Darrin in another PR.
   
   However, as an independent reviewer I don't like the sql only solution 
covers just (A) as it's not an elegant and re-usable solution, people won't 
remember the introduced sql procedure. An internal Java based API would be 
elegant and reusable. I'm bit surprised with your reply and conduct, and this 
PR since your other PRs have been quite clean and elegant. That said I don't 
intend to block or "mess" with this PR as it doesn't concern the issue I had 
logged.
   
   Please note I wasn't the one who added the on-hold label, I simply responded 
to your comment since you tagged me. It was 4.16 RM in their right towards 4.16 
milestone to put any labels or triage any issues or PRs. Nicolas maybe my 
dayjob work colleague but we've no influence on each other in our community 
work and communication which is evident by the fact that we all work remotely 
in different timezones and we often disagree that spills over both public and 
private ACS lists. So there's no attempt to "mess" with anyone, just 
misunderstanding on your part. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to