rhtyd commented on a change in pull request #5319:
URL: https://github.com/apache/cloudstack/pull/5319#discussion_r691825884
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -58,17 +58,11 @@ def process(self):
if self.conf.commit():
restart_dnsmasq = True
- if self.cloud.commit():
- restart_dnsmasq = True
-
- if self.dhcp_leases.commit():
- restart_dnsmasq = True
-
+ self.dhcp_hosts.commit()
+ self.dhcp_leases.commit()
self.dhcp_opts.commit()
- if restart_dnsmasq:
- self.delete_leases()
-
+ self.delete_leases()
self.write_hosts()
Review comment:
@weizhouapache can you explain what this line does? Isn't deleting
leases going to cause any regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
