weizhouapache commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-902465532
> We could do that @weizhouapache - However, my understanding is, if a null / empty uname / password is provided as part of any API args - the corresponding APIs logic would ideally validate the correctness of the input or the authorization would fails if it's empty - which is the assumption that we had even before this check was added by - #5136. @Pearl1594 If you can make sure that all required username/password have been verified, this pr is good to me. Otherwise, I suggest you change the fields from required to optional in the specific API (add host ?) and check if they are null in codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
