slavkap opened a new pull request #5349: URL: https://github.com/apache/cloudstack/pull/5349
### Description Fixes #4433 - `snapshot.backup.to.secondary=false` - Create 2 or more snapshots on Ceph/NFS - Create volume/template from a snapshot. The snapshot first is copied to secondary storage - Create volume/template from the second snapshot. The snapshot is not copied to secondary because the snapshot info is retrieved with the wrong SQL query. Operation fails. The problem appears on Ceph/NFS but it probably affects other storage plugins. Bypassing secondary storage is supported only for Ceph primary storage, but it didn't cover the functionality to create volumes from snapshots which are kept only on Ceph. With this fix, if you create snapshots only on NFS and try to create volume/template from a snapshot first, the snapshots are copied to secondary storage. For Ceph, the snapshot will be copied to secondary only when you create a template from a snapshot. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### How Has This Been Tested? Manual tests hypervisor KVM - create RBD volumes from RBD snapshots - the snapshots are not copied to secondary storage - create NFS volumes from RBD snapshots - the snapshots are not copied to secondary storage - create templates from RBD snapshots - the snapshot is copied to secondary storage - create templates from NFS snapshots - the snapshot is copied to secondary storage - create NFS volumes from NFS snapshots - the snapshot is copied to secondary storage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
