weizhouapache opened a new pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356
### Description
This PR fixes #4902
The testing results with this change:
- When destroy VM without expunge and when no data disk is selected for
deletion
destroy vm: VM is stopped, data disk is detached from vm (in Ready
state)
recover vm: vm is ready only with root disk.
- When destroy VM without expunge and when one or more data disks are
selected for deletion
destroy vm: VM is stopped, Data disks marked for deletion are
detached and in Destroy state . the remaining disks are detached from VM
recover vm: vm is ready only with root disk.
recover data disk in Destroy: volume is ready, and not attached to
vm.
- When destroy VM with expunge and when no data disk is selected for deletion
VM is destroyed and expunged completely.
data disks are detached from vm.
- When destroy VM with expunge and few data disks are selected for deletion
VM is destroyed and expunged completely.
Data disks marked for deletion are deleted. the remaining disks are
detached from VM
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*********************************************************************************
-->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*********************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
