DaanHoogland commented on a change in pull request #5349:
URL: https://github.com/apache/cloudstack/pull/5349#discussion_r697254336
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -497,6 +492,25 @@ public VolumeInfo createVolumeFromSnapshot(Volume volume,
Snapshot snapshot, Use
}
+ private SnapshotInfo backupSnapshotIfNeeded(Snapshot snapshot,
DataStoreRole dataStoreRole, SnapshotInfo snapInfo) {
+ boolean backupSnapToSecondary =
SnapshotManager.BackupSnapshotAfterTakingSnapshot.value() == null ||
SnapshotManager.BackupSnapshotAfterTakingSnapshot.value();
+
+ StoragePoolVO srcPool =
_storagePoolDao.findById(snapInfo.getBaseVolume().getPoolId());
+ // We need to copy the snapshot onto secondary.
+ //Skipping the backup to secondary storage with NFS/FS could be
supported when CLOUDSTACK-5297 is accepted with small enhancement in:
+ //KVMStorageProcessor::createVolumeFromSnapshot and
CloudStackPrimaryDataStoreDriverImpl::copyAsync/createAsync
Review comment:
potential javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
