weizhouapache commented on a change in pull request #5390:
URL: https://github.com/apache/cloudstack/pull/5390#discussion_r699041000
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -886,6 +886,7 @@ public UserVm resetVMSSHKey(ResetVMSSHKeyCmd cmd) throws
ResourceUnavailableExce
throw new CloudRuntimeException("Failed to reset SSH Key for the
virtual machine ");
}
+ _vmDao.loadDetails(userVm);
Review comment:
@nvazquez done.
details are loaded but not updated, therefore it does not contain the new
ssh key.
##########
File path:
server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java
##########
@@ -254,10 +254,6 @@ public boolean saveSSHKey(final Network network, final
NicProfile nic, final Vir
final boolean canHandle = canHandle(network.getTrafficType());
- if (canHandle) {
Review comment:
since password is not reset when reset sshkey (in #4819 ), it is not
needed to save password in vm details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
