rhtyd edited a comment on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-918837390
We need test matrix on this @nvazquez General note: such a refactoring PR worries me closer to a RC, I've seen my share of blockers which get introduced due to refactoring changes as there are so many paths which may not be covered 100% by smoketests. I suggest the RM to discuss with the author and other reviewers and take the call whether we want the risk or if there's a risk. One specific review feedback - I didn't like is manual json strings, for example use a utility to convert specific field of a class to json? @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
