davidjumani commented on a change in pull request #5369:
URL: https://github.com/apache/cloudstack/pull/5369#discussion_r709800773
##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -495,6 +495,27 @@ def config(self):
logging.debug(formatExceptionInfo())
return False
+class hostConfig(serviceCfgBase):
+ def __init__(self, syscfg):
+ super(hostConfig, self).__init__(syscfg)
+ self.serviceName = "Host"
+
+ def config(self):
+ try:
+ cfo = configFileOps("/etc/cloudstack/agent/agent.properties", self)
+ reservedMemory =
float(cfo.getEntry("host.reserved.mem.mb").strip() or 1024)
+ totalMemory = float(bash("awk '/MemTotal/ { printf \"%.3f \\n\",
$2/1024 }' /proc/meminfo").getStdout().strip())
+ if totalMemory < reservedMemory :
+ raise CloudRuntimeException("CloudStack requires more than %d
MB memory since %d MB is reserved" %(reservedMemory, reservedMemory))
+
+ if int(bash('ip a | grep "^\\w" | grep -iv "^lo" | wc
-l').getStdout()) < 1 :
Review comment:
Yes, it counts all nics excluding loopback
In some minimal instances lshw is not present, so using IP -a since that is
pretty much always there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
