shwstppr commented on a change in pull request #5181:
URL: https://github.com/apache/cloudstack/pull/5181#discussion_r709969391
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4042,16 +4042,6 @@ private NicProfile orchestrateAddVmToNetwork(final
VirtualMachine vm, final Netw
//3) Convert nicProfile to NicTO
final NicTO nicTO = toNicTO(nic,
vmProfile.getVirtualMachine().getHypervisorType());
- if (network != null) {
- final Map<NetworkOffering.Detail, String> details =
networkOfferingDetailsDao.getNtwkOffDetails(network.getNetworkOfferingId());
- if (details != null) {
-
details.putIfAbsent(NetworkOffering.Detail.PromiscuousMode,
NetworkOrchestrationService.PromiscuousMode.value().toString());
-
details.putIfAbsent(NetworkOffering.Detail.MacAddressChanges,
NetworkOrchestrationService.MacAddressChanges.value().toString());
-
details.putIfAbsent(NetworkOffering.Detail.ForgedTransmits,
NetworkOrchestrationService.ForgedTransmits.value().toString());
- }
- nicTO.setDetails(details);
- }
Review comment:
@sureshanaparti moved to HypervisorGuruBase. The method at line 4043 was
calling `HypervisorBaseGuru::toNicTO` and then setting these details. Since
`HypervisorBaseGuru::toNicTO` has been refactored to include this code setting
these details again was not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
