SadiJr commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r711295747
##########
File path:
plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java
##########
@@ -149,7 +152,7 @@ public boolean assignVMToBackupOffering(final
VirtualMachine vm, final BackupOff
for (final BackupOffering job : client.listJobs()) {
if (job.getName().equals(clonedJobName)) {
final Job clonedJob = client.listJob(job.getExternalId());
- if (clonedJob.getScheduleConfigured() &&
!clonedJob.getScheduleEnabled()) {
+ if (BooleanUtils.isTrue(clonedJob.getScheduleConfigured()) &&
!clonedJob.getScheduleEnabled()) {
Review comment:
Because `BooleanUtils.isTrue()` is null safe, and the method
`client.listJob(job.getExternalId())` can return null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
