DaanHoogland commented on pull request #5505:
URL: https://github.com/apache/cloudstack/pull/5505#issuecomment-927618219


   @rhtyd @Pearl1594 if the super method is called `cls._cleanup` will be 
reversed in that method.
   ```
       @classmethod
       def tearDownClass(cls):
           try:
               # Cleanup resources used
               cleanup_resources(cls.apiclient, cls._cleanup)
           except Exception as e:
               raise Exception("Warning: Exception during cleanup : %s" % e)
           return
   ```
   should be 
   ```
       @classmethod
       def tearDownClass(cls):
           super(TestSnapshotRootDisk, cls).tearDownClass()
   ```
   and every creation should be followed by an immediate add to ether 
`cls._cleanup` or `self.cleanup`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to