sureshanaparti commented on a change in pull request #5504:
URL: https://github.com/apache/cloudstack/pull/5504#discussion_r717294026
##########
File path:
server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java
##########
@@ -481,17 +478,11 @@ public Long getDelay() {
private void cleanupOldDiagnosticFiles(DataStore store) {
String mountPoint = null;
- try {
- mountPoint =
serviceImpl.mountManager.getMountPoint(store.getUri(), null);
- if (StringUtils.isNotBlank(mountPoint)) {
- File directory = new File(mountPoint + File.separator +
DIAGNOSTICS_DIRECTORY);
- if (directory.isDirectory()) {
- deleteOldDiagnosticsFiles(directory, store.getName());
- }
- }
- } finally {
- if (StringUtils.isNotBlank(mountPoint)) {
- umountSecondaryStorage(mountPoint);
+ mountPoint =
serviceImpl.mountManager.getMountPoint(store.getUri(), null);
+ if (StringUtils.isNotBlank(mountPoint)) {
+ File directory = new File(mountPoint + File.separator +
DIAGNOSTICS_DIRECTORY);
+ if (directory.isDirectory()) {
+ deleteOldDiagnosticsFiles(directory, store.getName());
Review comment:
@Pearl1594 any update on this ^^^ , possible to fix this permission
issue for VMware only?
##########
File path:
server/src/main/java/org/apache/cloudstack/diagnostics/DiagnosticsServiceImpl.java
##########
@@ -481,17 +478,11 @@ public Long getDelay() {
private void cleanupOldDiagnosticFiles(DataStore store) {
String mountPoint = null;
- try {
- mountPoint =
serviceImpl.mountManager.getMountPoint(store.getUri(), null);
- if (StringUtils.isNotBlank(mountPoint)) {
- File directory = new File(mountPoint + File.separator +
DIAGNOSTICS_DIRECTORY);
- if (directory.isDirectory()) {
- deleteOldDiagnosticsFiles(directory, store.getName());
- }
- }
- } finally {
- if (StringUtils.isNotBlank(mountPoint)) {
- umountSecondaryStorage(mountPoint);
+ mountPoint =
serviceImpl.mountManager.getMountPoint(store.getUri(), null);
+ if (StringUtils.isNotBlank(mountPoint)) {
+ File directory = new File(mountPoint + File.separator +
DIAGNOSTICS_DIRECTORY);
+ if (directory.isDirectory()) {
+ deleteOldDiagnosticsFiles(directory, store.getName());
Review comment:
OK @Pearl1594 , Got it. I think, keeping secondary store mounted always
on all the hypervisors is also not good. Only SSVM should have the access to it
always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
