weizhouapache commented on a change in pull request #5501:
URL: https://github.com/apache/cloudstack/pull/5501#discussion_r717371907



##########
File path: engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java
##########
@@ -217,6 +218,15 @@ public VolumeVO findByPoolIdName(long poolId, String name) 
{
         return listBy(sc);
     }
 
+    @Override
+    public List<VolumeVO> findReadyAndAllocatedRootVolumesByInstance(long 
instanceId) {

Review comment:
       @DaanHoogland for kvm, there is only 1 root disk. 
   for other hypervisors eg vmware, I have no idea. 
   so I'd like to use similar code as findReadyRootVolumesByInstance which 
returns a list of root volumes and processed in other java files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to