DaanHoogland commented on a change in pull request #5382:
URL: https://github.com/apache/cloudstack/pull/5382#discussion_r718259812
##########
File path:
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41520to41600.java
##########
@@ -65,6 +68,31 @@ public boolean supportsRollingUpgrade() {
@Override
public void performDataMigration(Connection conn) {
generateUuidForExistingSshKeyPairs(conn);
+ fixWrongPoolUuid(conn);
+ }
+
+ public void fixWrongPoolUuid(Connection conn) {
+ LOG.debug("Replacement of faulty pool uuids");
+ try (PreparedStatement pstmt = conn.prepareStatement("SELECT id,uuid
FROM storage_pool "
+ + "WHERE removed IS NULL;"); ResultSet rs =
pstmt.executeQuery()) {
+ PreparedStatement updateStmt = conn.prepareStatement("update
storage_pool set uuid = ? where id = ?");
+ while (rs.next()) {
+ if (!rs.getString(2).contains("-")) {
Review comment:
can we make this part of the where-clause of the select statement
already? no reason to try and fix anything that isn't broken. (also is this
condition good and enough?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
