sureshanaparti commented on a change in pull request #5544:
URL: https://github.com/apache/cloudstack/pull/5544#discussion_r721267205
##########
File path:
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -304,7 +304,10 @@ public Snapshot revertSnapshot(Long snapshotId) {
SnapshotInfo snapshotInfo = snapshotFactory.getSnapshot(snapshotId,
dataStoreRole);
Review comment:
@slavkap the datastore role for the snapshot is picked based to where it
is stored (Image | Primary), doesn't matter what the config
"snapshot.backup.to.secondary" is. So, no need to re-check _snapshotInfo_ with
the "DataStoreRole.Primary" role.
https://github.com/apache/cloudstack/blob/e5a12ff12cd047c70b3c541c85512374741930fc/server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java#L1292-L1293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
