SadiJr opened a new pull request #5650:
URL: https://github.com/apache/cloudstack/pull/5650


   ### Description
   
   In VMWare, there are different types of SCSI controllers, such as BusLogic 
Parallel, LSI Logic Parallel, LSI Logic SAS, etc. All of these sub-types 
support the disk resize operation, the only exception is the IDE controller. 
However, in ACS, there is a logical restriction to allow only resizing of 
volumes of the specific `SCSI` type; thus, not allowing resizing of the SCSI 
sub-types. This PR corrects this behavior blocking the resize of volumes which 
uses `IDE` controller only.
   More information can be found at:
   - https://www.starwindsoftware.com/blog/storage-controllers-in-vmware-vsphere
   - 
https://www.nakivo.com/blog/scsi-controller-and-other-vmware-controller-types/
   - 
https://docs.vmware.com/en/VMware-vSphere/7.0/com.vmware.vsphere.vm_admin.doc/GUID-5872D173-A076-42FE-8D0B-9DB0EB0E7362.html
   - 
https://communities.vmware.com/t5/ESXi-Discussions/Unable-to-increase-disk-Space/td-p/397823
   
   # Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   - [ ] Major
   - [x] Minor
   
   ### How Has This Been Tested?
   I tested it in a local lab:
   1. I created a VM with `lsisas1068 SAS` controller.
   2. I tried to resize the volume and got this error message: "Found 
unsupported root disk controller: lsisas1068".
   3. With the changes from this PR, I was able to resize the volume correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to