DaanHoogland commented on a change in pull request #5687:
URL: https://github.com/apache/cloudstack/pull/5687#discussion_r754120015
##########
File path:
server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
##########
@@ -521,13 +520,21 @@ public void checkResourceLimit(final Account account,
final ResourceType type, l
}
final Project projectFinal = project;
+
+ // Check account limits. If it's unlimited then don't lock the db rows
+ long accountResourceLimit =
findCorrectResourceLimitForAccount(account, type);
+ if (Resource.RESOURCE_UNLIMITED == accountResourceLimit) {
Review comment:
no it doesn't @ravening
say Dom1 has a limit of 10
acc1 has a limit of 4
acc2 has a limit of -1
now acc1 can get 4 resources unless acc2 takes 8, but still together they
can't take more than 10.
in this case the -1 is a convenience of not having to copy the domain limit,
but also when changing the domain limit, you don't have to adjust acc2 for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
