ravening commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r770512502
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4922,7 +4922,9 @@ public boolean releasePublicIpRange(final
ReleasePublicIpRangeCmd cmd) {
public boolean releasePublicIpRange(final long vlanDbId, final long
userId, final Account caller) {
VlanVO vlan = _vlanDao.findById(vlanDbId);
if(vlan == null) {
- s_logger.warn("VLAN information for Account '" + caller + "', User
'" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+ // Nothing to do if vlan can't be found
+ s_logger.warn("VLAN information for Account '" + caller + "', User
'" + userId + "' VLAN '" + vlanDbId + "' is null.");
+ return true;
Review comment:
@DaanHoogland yes, what @GabrielBrascher says is correct.. since vlan
cant be found in db, just return true rather than proceeding further.. i will
make the required changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
