sureshanaparti commented on a change in pull request #5801:
URL: https://github.com/apache/cloudstack/pull/5801#discussion_r774501350



##########
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
##########
@@ -1463,7 +1463,7 @@ public Answer createVolume(final CreateObjectCommand cmd) 
{
             primaryPool = 
storagePoolMgr.getStoragePool(primaryStore.getPoolType(), 
primaryStore.getUuid());
             disksize = volume.getSize();
             PhysicalDiskFormat format;
-            if (volume.getFormat() == null) {
+            if (volume.getFormat() == null || 
StoragePoolType.RBD.equals(primaryStore.getPoolType())) {

Review comment:
       To set the format after volume creation, check here: 
https://github.com/apache/cloudstack/blob/b32f3697e6f98ca209bba222fa8c58112f94d85f/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java#L663
   
   Irrespective of the current disk format, update to RAW when pool type is RBD.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to