weizhouapache commented on a change in pull request #5802:
URL: https://github.com/apache/cloudstack/pull/5802#discussion_r775012445
##########
File path:
plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
##########
@@ -416,25 +416,6 @@ public void testCreateDevicesDef() {
verifyDevices(devicesDef, to);
}
- @Test
Review comment:
@RohitYadavCloud
I just had a look at the test again. I think we should not remove the test.
we could apply the following change
```
- libvirtComputingResourceSpy._guestCpuArch = "aarch64";
+ to.setPlatformEmulator("Other PV Virtio-SCSI");
```
unit test will pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
