rohityadavcloud commented on a change in pull request #5873:
URL: https://github.com/apache/cloudstack/pull/5873#discussion_r786698816
##########
File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java
##########
@@ -2065,10 +2071,14 @@ public boolean restartNetwork(Long networkId, boolean
cleanup, boolean makeRedun
public boolean restartNetwork(RestartNetworkCmd cmd) throws
ConcurrentOperationException, ResourceUnavailableException,
InsufficientCapacityException {
// This method restarts all network elements belonging to the network
and re-applies all the rules
Long networkId = cmd.getNetworkId();
+ NetworkVO network = getNetworkVO(cmd.getNetworkId(),"Nework to restart
not found %s", String.valueOf(networkId));
boolean cleanup = cmd.getCleanup();
+ if (network.getVpcId() != null && cleanup) {
Review comment:
Wouldn't this break if restartVpc is called with cleanup=true (this has
been historically there?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
