sureshanaparti commented on a change in pull request #5992:
URL: https://github.com/apache/cloudstack/pull/5992#discussion_r806470096
##########
File path: test/integration/smoke/test_service_offerings.py
##########
@@ -811,8 +815,27 @@ def test_06_disk_offering_strictness_false(self):
"Check service offering of the VM"
)
+ self.updateVmwareSettings(True)
Review comment:
Can you revert to the actual value (can be 'true' or 'false') set before
executing this test.
##########
File path: test/integration/smoke/test_service_offerings.py
##########
@@ -811,8 +815,27 @@ def test_06_disk_offering_strictness_false(self):
"Check service offering of the VM"
)
+ self.updateVmwareSettings(True)
Review comment:
this is true for the tests are executed immediately in a fresh env as
the default value is set to `false`. But, when the test is executed in
fresh/upgraded env where the config is already modified to 'true', config value
is set to 'false' after the test.
##########
File path: test/integration/smoke/test_service_offerings.py
##########
@@ -811,8 +815,27 @@ def test_06_disk_offering_strictness_false(self):
"Check service offering of the VM"
)
+ self.updateVmwareSettings(True)
Review comment:
this is true for the tests are executed immediately in a fresh env as
the default value is set to `false`. But, when the test is executed in
fresh/upgraded env where the config is already modified to `true`, config value
is set to `false` after the test.
##########
File path: test/integration/smoke/test_service_offerings.py
##########
@@ -811,8 +815,27 @@ def test_06_disk_offering_strictness_false(self):
"Check service offering of the VM"
)
+ self.updateVmwareSettings(True)
Review comment:
this is true for the tests that are executed immediately in a fresh env
as the default value is set to `false`. But, when the test is executed in
fresh/upgraded env where the config is already modified to `true`, config value
is set to `false` after the test.
##########
File path: test/integration/smoke/test_service_offerings.py
##########
@@ -715,6 +717,10 @@ def test_06_disk_offering_strictness_false(self):
if self.hypervisor.lower() == "lxc":
self.skipTest("Skipping this test for {} due to bug
CS-38153".format(self.hypervisor))
+ fullClone = Configurations.list(self.apiclient,
name="vmware.create.full.clone")
Review comment:
call this when hypervisor is VMware
##########
File path: test/integration/smoke/test_service_offerings.py
##########
@@ -811,8 +817,28 @@ def test_06_disk_offering_strictness_false(self):
"Check service offering of the VM"
)
+ if fullClone[0].value.lower() == "false":
+ self.updateVmwareSettings(True)
+
return
+ def updateVmwareSettings(self, tearDown):
Review comment:
send the value instead of tearDown
```suggestion
def updateVmwareCreateFullCloneSetting(self, value):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
