weizhouapache commented on a change in pull request #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r808850809
##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -2424,7 +2425,9 @@ private void setParameters(SearchCriteria<IPAddressVO>
sc, final ListPublicIpAdd
sc.setParameters("state", state);
}
- sc.setParameters( "forsystemvms", false);
+ if (sourceNetworkId == null &&
IpAddressManagerImpl.SystemVmPublicIpReservationModeStrictness.value()) {
+ sc.setParameters("forsystemvms", false);
+ }
Review comment:
@SadiJr
I have two questions
(1) if the global setting is `true`, can the IP (in the reserved ip range
but used by uservm) listed by api ?
(2) if the global setting is `false`, can domain admin and normal users see
the public ips used by systemvms ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
