DaanHoogland commented on a change in pull request #5909:
URL: https://github.com/apache/cloudstack/pull/5909#discussion_r817576503
##########
File path:
engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotInfo.java
##########
@@ -18,10 +18,16 @@
import java.util.List;
+import org.apache.cloudstack.framework.config.ConfigKey;
+
import com.cloud.storage.Snapshot;
import com.cloud.utils.exception.CloudRuntimeException;
public interface SnapshotInfo extends DataObject, Snapshot {
+ ConfigKey<Boolean> BackupSnapshotAfterTakingSnapshot = new
ConfigKey<Boolean>(Boolean.class, "snapshot.backup.to.secondary", "Snapshots",
"true", "Indicates whether to always"
Review comment:
hm, reasonable explanation, it still doesn't feel good. I don't want to
be dogmatic about it, but let's keep thinking about this. If we can't find a
better way, soit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
