weizhouapache commented on pull request #6046: URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1069354155
> Code LGTM. Small points: > > * When reserving an IP for an account, it would be nice, if the account for which the IP has been reserved has the ability to release the address > * For a reserved IP address - it would be better if we could hide the Firewall, LB and protforwarding tab - this isn't major, can be addressed later too. > Thanks @weizhouapache thanks @Pearl1594 for review I have addressed your comments (1) both apis are available for domain admins and regular users, same as associate/disassociate public ip (2) the tabs on UI and other UI issues (due to vue3 upgrade) has been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
