harikrishna-patnala commented on code in PR #6483:
URL: https://github.com/apache/cloudstack/pull/6483#discussion_r907011726
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java:
##########
@@ -1104,13 +1124,22 @@ public List<Command> finalizeMigrate(VirtualMachine vm,
Map<Volume, StoragePool>
if (pool.getClusterId() != null) {
poolClusterId = pool.getClusterId();
}
+ if (volume.getVolumeType().equals(Volume.Type.ROOT) &&
pool.isLocal()) {
+ isLocalStorageMigration = true;
+ }
volumeToFilerTo.add(new Pair<VolumeTO, StorageFilerTO>(volumeTo,
filerTo));
}
final Long destClusterId = poolClusterId;
final Long srcClusterId =
vmManager.findClusterAndHostIdForVm(vm.getId()).first();
final boolean isInterClusterMigration =
isInterClusterMigration(destClusterId, srcClusterId);
+ String targetHostGuid = null;
+ if (isLocalStorageMigration) {
Review Comment:
Ideally, targetHostGuid in case of local storage should not return null.
Also I have not changed the code in the before review comment, so I would like
to keep it as is. Please suggest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
