weizhouapache commented on code in PR #6507:
URL: https://github.com/apache/cloudstack/pull/6507#discussion_r934340728


##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java:
##########
@@ -2126,6 +2126,11 @@ public boolean finalizeVirtualMachineProfile(final 
VirtualMachineProfile profile
             }
         }
 
+        String routerLogrotateFrequency = 
RouterLogrotateFrequency.valueIn(router.getDataCenterId());
+        s_logger.debug(String.format("The setting [%s] with value [%s] for the 
zone with UUID [%s], will be used to configure the logrotate service frequency" 
+
+                        " on the virtual router.", 
RouterLogrotateFrequency.key(), routerLogrotateFrequency, dc.getUuid()));
+        buf.append(String.format(" logrotatefrequency=%s", 
routerLogrotateFrequency));

Review Comment:
   @RodrigoDLopez 
   is there a check on the value so that the logrotate will not be broken due 
to invalid value ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to