DaanHoogland commented on code in PR #6587:
URL: https://github.com/apache/cloudstack/pull/6587#discussion_r936755553
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java:
##########
@@ -678,6 +682,32 @@ protected void updateVolumeInfo(VolumeObjectTO newVolume,
VolumeVO volumeVo, boo
s_logger.debug(String.format("Updated %s from %s to %s ",
volumeVo.getVolumeDescription(), previousValues, newValues));
}
+ protected void updateResourceCount(VolumeObjectTO newVolume, VolumeVO
volumeVo) {
+ if (newVolume == null || newVolume.getSize() == null || volumeVo ==
null || volumeVo.getSize() == null) {
Review Comment:
```suggestion
if (newVolume == null || newVolume.getSize() == null || oldVolume ==
null || oldVolume.getSize() == null) {
```
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java:
##########
@@ -678,6 +682,32 @@ protected void updateVolumeInfo(VolumeObjectTO newVolume,
VolumeVO volumeVo, boo
s_logger.debug(String.format("Updated %s from %s to %s ",
volumeVo.getVolumeDescription(), previousValues, newValues));
}
+ protected void updateResourceCount(VolumeObjectTO newVolume, VolumeVO
volumeVo) {
Review Comment:
```suggestion
protected void updateResourceCount(VolumeObjectTO newVolume, VolumeVO
oldVolume) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
