mlsorensen commented on code in PR #6522:
URL: https://github.com/apache/cloudstack/pull/6522#discussion_r938971510
##########
core/src/main/java/org/apache/cloudstack/storage/to/VolumeObjectTO.java:
##########
@@ -357,4 +366,22 @@ public String getvSphereStoragePolicyId() {
public void setvSphereStoragePolicyId(String vSphereStoragePolicyId) {
this.vSphereStoragePolicyId = vSphereStoragePolicyId;
}
+
+ public String getEncryptFormat() { return encryptFormat; }
+
+ public void setEncryptFormat(String encryptFormat) { this.encryptFormat =
encryptFormat; }
+
+ public byte[] getPassphrase() { return passphrase; }
+
+ public void setPassphrase(byte[] passphrase) { this.passphrase =
passphrase; }
Review Comment:
@JoaoJandre - I was going to change these, but in reviewing VolumeObjectTO,
if I change them they'll be (almost) the only getters and setters that are not
single line blocks, and there are a lot of them. What do you think, is it
better to adhere to the existing style, and perhaps come back and audit the
code if the standard dictates changes are needed - or do we just have mixed
style as new commits come in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
