BryanMLima opened a new pull request, #6684:
URL: https://github.com/apache/cloudstack/pull/6684

   ### Description
   
   This PR aims to improve the user experience upon creation of Network 
Offerings warning the user of the scenarios in which a VR is created. For this, 
the service offering field is always shown in the form and a warning message is 
displayed if the user's configuration does not require the creation of a VR. 
These scenarios include a network offering with guest type L2, and a with a 
guest type Shared or Isolated when none of the following services are enabled: 
(VPN, DHCP, DNS, Firewall, LB, UserData, SourceNat, StaticNat and/or 
PortForwarding). Finally, the message for the Isolated and Shared networks 
disappear when one of the aforementioned services are selected.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   Message if the guest type is **Isolated or Shared**:
   
![image](https://user-images.githubusercontent.com/42067040/187272985-65a3715e-36eb-406f-a8e6-ae0d89dc7eb4.png)
     
   Message if the guest type is **L2**:
   
![image](https://user-images.githubusercontent.com/42067040/187273080-d6185ad5-46e1-49d0-afd0-25a5f2de3a71.png)
   
   
   ### How Has This Been Tested?
   This was tested in a local lab using the networking offering form. The 
message for Shared/Isolated type was only displayed if the none of the 
following services (VPN, DHCP, DNS, Firewall, LB, UserData, SourceNat, 
StaticNat and/or PortForwarding) were not selected.
   For the L2 message, it was always displayed, unless the guest type was 
changed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to