DaanHoogland commented on PR #6685: URL: https://github.com/apache/cloudstack/pull/6685#issuecomment-1231886838
@JoaoJandre in itself the code looks good but I have a problem with the design; a join dao is supposed to get data from a view and not to manippulate or augment it. This is more in place in the service serving the API command. What made you decide to implement it like this? (in the `..JoinDaoImpl` classes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
