DaanHoogland commented on code in PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#discussion_r964474485


##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,112 @@
 --;
 
 UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 
'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 
'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 
'consoleproxy.disable.rpfilter' AND `value` != 'true';
+

Review Comment:
   sorry @neogismm I do not understand the entire background. Are you saying 
you included code for other branches in this one? If you base your changes on 
main that shouldn´t happen. You can clean up your local working branch and 
force push it to your github branch to clean it up. There is no need for a new 
PR. 
   But these schema changes for 4.17 are not wanted, i'd say. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to