DaanHoogland commented on code in PR #6710:
URL: https://github.com/apache/cloudstack/pull/6710#discussion_r968206827
##########
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##########
@@ -2619,6 +2625,14 @@ public List<String[]> generateVmData(String userData,
String serviceOffering, lo
vmData.add(new String[]{PASSWORD_DIR, PASSWORD_FILE, password});
}
vmData.add(new String[]{METATDATA_DIR, HYPERVISOR_HOST_NAME_FILE,
hostname});
+
+ Domain domain = _domainDao.findById(vm.getDomainId());
+ if (domain != null &&
VirtualMachineManager.AllowExposeDomainInMetadata.valueIn(domain.getId())) {
+ s_logger.debug("Adding domain info to cloud metadata");
Review Comment:
@GutoVeronezi could that be a possible security concern? having private user
data in the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
