weizhouapache commented on PR #6699: URL: https://github.com/apache/cloudstack/pull/6699#issuecomment-1245007292
> @weizhouapache > > I would also prefer to ignore number 1. For everything else, I can adapt the source code. > > But I still have two questions. (on point 3. and 4. - create/remove libvirt storage pool ) Does it make sense that Cloudstack can create local storage? I had thought about that, but I came to the conclusion that it would be a break in logic. As far as I know (KVM, VMware) cloudstack does not create storages. CS only adds them to its own infrastructure. > > Why do the agent properties have to be adapted? My PR works completely without the agent properties and so far I have not noticed any errors that would require an adjustment in the agent properties. I can add/remove local storages. Create/delete/migrate VM's. @DK101010 when cloudstack agent is started or restarted, it will (1) read the storage pools (uuid and path) in agent.properties (2) create libvirt storage pools (not the directory itself) if not exist. you can check `createLocalStoragePool` method in https://github.com/apache/cloudstack/blob/main/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L3419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
