weizhouapache commented on code in PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#discussion_r970760805
##########
server/src/test/java/com/cloud/network/lb/LoadBalancingRulesManagerImplTest.java:
##########
@@ -100,7 +100,5 @@ public void testGetLoadBalancerServiceProviderFail() {
when(_networkMgr.getProvidersForServiceInNetwork(networkMock,
Network.Service.Lb)).thenReturn(new ArrayList<>());
Network.Provider provider =
lbr.getLoadBalancerServiceProvider(loadBalancerMock);
-
- Assert.assertNull(provider);
Review Comment:
@DaanHoogland
the test gives an exception so `provider` is always null.
(actually code smell asked me to remove it ...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
