JoaoJandre commented on PR #6772: URL: https://github.com/apache/cloudstack/pull/6772#issuecomment-1261088013
> @JoaoJandre did you look at the flow for `changeOfferingForVolume`, `migrateVolume`, `resizeVolume` and `updateVolume`? Not sure but the code you extracted may be used there as well. Please check, CLGTM otherwise. @DaanHoogland I checked these flows and the event publishes in these places are a bit different, the ones I saw at least already had the `diskOfferingVO` available, so if we used the new method I extracted we would be making an unnecessary call to the DB. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
