BryanMLima opened a new pull request, #6812: URL: https://github.com/apache/cloudstack/pull/6812
### Description ACS encrypts the configuration values from accounts and domains, e.g. `AccountDetailVO` and `DomainDetailVO` while plain values are stored in the DB on data center and cluster scopes, e.g. `DataCenterDetailVO` and `ClusterDetailVO`. However, there are many different configuration values that make no sense to encrypt. The only ones that should be encrypted are in the secure/hidden category. Furthermore, there are use cases when retrieving the value on a DB view is needed, which is impossible with the current process in the account and domain scopes. Moreover, the response while updating a configuration value now returns the encrypted value for the categories mentioned above. This PR aims to normalize the encryption on these four scopes; for this, all values that are not in the secure/hidden category are not encrypted. Furthermore, an unused mock file was removed due to a requirement to add a mock method to this class that was not even used. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor ### Screenshots (if appropriate): Domain details table before changes:  Domain details table after changes:  Update configuration value response after these changes:  These images are just an example, these changes are for all four tables mentioned above. ### How Has This Been Tested? This was tested in a local lab generating a new version for the `.deb` file of CloudStack. The lab upgraded successfully and the DB script ran smoothly. There were custom configuration values for all four scopes in the DB, the image in the screenshot section presents the result of the upgrade in the `domain_details` table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
