DaanHoogland commented on code in PR #6812:
URL: https://github.com/apache/cloudstack/pull/6812#discussion_r995568848
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41710to41800.java:
##########
@@ -124,10 +124,10 @@ protected Map<Long, String>
selectValuesWithCustomConfigs(Connection conn, Strin
}
}
- protected void executeUpdateOnConfigValues(Connection conn, Map<Long,
String> valuesMapToBeUpdated, String table) {
+ protected void updateConfigValuesWithScope(Connection conn, Map<Long,
String> configsToBeUpdated, String table) {
String updateConfigValues = String.format("UPDATE cloud.%s SET value =
? WHERE id = ?;", table);
- for (Map.Entry<Long, String> map : valuesMapToBeUpdated.entrySet()) {
+ for (Map.Entry<Long, String> config : valuesMapToBeUpdated.entrySet())
{
Review Comment:
changed the name from `map` to `config`, but in the code below `map` is
still referenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
