JoaoJandre commented on code in PR #6781:
URL: https://github.com/apache/cloudstack/pull/6781#discussion_r995939043
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6748,6 +6737,31 @@ public Pair<List<? extends NetworkOffering>, Integer>
searchForNetworkOfferings(
}
}
+ private boolean allowNetworkOfferingWithNullTag(Long zoneId, List<String>
pNtwkTags) {
+ boolean allowNullTag = false;
+ final List<PhysicalNetworkVO> pNtwks =
_physicalNetworkDao.listByZoneAndTrafficType(zoneId, TrafficType.Guest);
Review Comment:
```suggestion
private boolean allowNetworkOfferingWithNullTag(Long zoneId,
List<String> physicalNetworkTags) {
boolean allowNullTag = false;
final List<PhysicalNetworkVO> physicalNetworks =
_physicalNetworkDao.listByZoneAndTrafficType(zoneId, TrafficType.Guest);
```
I think we should make variable names readable and understandable to avoid
confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
