DaanHoogland commented on code in PR #6012:
URL: https://github.com/apache/cloudstack/pull/6012#discussion_r999075541


##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -692,8 +692,13 @@ private Pair<DiskProfile, StoragePool> 
importDisk(UnmanagedInstanceTO.Disk disk,
             chainInfo = gson.toJson(diskInfo);
         }
         StoragePool storagePool = getStoragePool(disk, zone, cluster);
+
+        if ( useControllerConfiguration ){

Review Comment:
   @DK101010 , this is one of the code smells and it is easily fixed:
   ```suggestion
           if (Boolean.TRUE.equals(useControllerConfiguration)) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to